[coreboot-gerrit] [M] Change in coreboot[master]: mb/msi/ms7d25: Add support for DDR5 variant

[Michał Żygowski (Code Review)]

Attention is currently required from: Felix Singer, Paul Menzel, Michał Kopeć, Angel Pons.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68448 )

Change subject: mb/msi/ms7d25: Add support for DDR5 variant
......................................................................

Patch Set 6:

(3 comments)

File src/mainboard/msi/ms7d25/Kconfig:

https://review.coreboot.org/c/coreboot/+/68448/comment/c99e6896_074ea40c 
PS3, Line 4: config BOARD_MSI_Z690_A_PRO_WIFI
> It is just Kconfig name and does not really matter. […]

Done

File src/mainboard/msi/ms7d25/Kconfig.name:

https://review.coreboot.org/c/coreboot/+/68448/comment/6cc95d95_41afbca1 
PS3, Line 2: 	bool "PRO Z690-A (WIFI) DDR4"
> WIFI is optional here thus the parentheses. […]

Ack

File src/mainboard/msi/ms7d25/romstage_fsp_params.c:

https://review.coreboot.org/c/coreboot/+/68448/comment/5411b70d_772e6ada 
PS2, Line 71: 	if (CONFIG(BOARD_MSI_Z690_A_PRO_WIFI_DDR4))
            : 		memcfg_init(memupd, &ddr4_mem_config, &dimm_module_spd_info, false);
            : 	if (CONFIG(BOARD_MSI_Z690_A_PRO_WIFI))
            : 		memcfg_init(memupd, &ddr5_mem_config, &dimm_module_spd_info, false);
> There are actually no more variants of the ms7d25 board. So this will be the last one. […]

Ack