EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35141 )
Change subject: mb/google/drallion: Add memory init setup for drallion
......................................................................
Patch Set 25:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35141/25/src/mainboard/google/drall...
File src/mainboard/google/drallion/romstage.c:
https://review.coreboot.org/c/coreboot/+/35141/25/src/mainboard/google/drall...
PS25, Line 23: const struct cnl_mb_cfg *__weak_variant_memory_params(void)
You can pass the memcfg and return it directly.
weak_variant_memory_params(struct cnl_mb_cfg memcfg)
{
return mem_cfg;
}
https://review.coreboot.org/c/coreboot/+/35141/25/src/mainboard/google/drall...
PS25, Line 29: static const struct cnl_mb_cfg memcfg = {
Remove static const here, because we want to override it.
https://review.coreboot.org/c/coreboot/+/35141/25/src/mainboard/google/drall...
PS25, Line 70: variant_memory_params();
Nothing happens here. You should pass the memcfg for override it.
variant_memory_params(memcfg);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9993ad175e6f52711d5a05733aeab1bbed1e0b80
Gerrit-Change-Number: 35141
Gerrit-PatchSet: 25
Gerrit-Owner: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.com
Gerrit-Reviewer: Thejaswani Putta
thejaswani.putta@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aamir Bohra
aamir.bohra@intel.com
Gerrit-CC: AndreX Andraos
andrex.andraos@intel.com
Gerrit-CC: Bernardo Perez Priego
bernardo.perez.priego@intel.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Chiranjeevi Rapolu
chiranjeevi.rapolu@intel.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Krzysztof M Sywula
krzysztof.m.sywula@intel.com
Gerrit-CC: Mathew King
mathewk@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-CC: Varun Joshi
varun.joshi@intel.com
Gerrit-Comment-Date: Tue, 17 Sep 2019 03:51:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment