Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38682 )
Change subject: src/soc/tigerlake: Define and use config for number of USB2/3 ports.
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38682/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38682/4//COMMIT_MSG@7
PS4, Line 7: .
not needed.
https://review.coreboot.org/c/coreboot/+/38682/4/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params_jsl.c:
https://review.coreboot.org/c/coreboot/+/38682/4/src/soc/intel/tigerlake/fsp...
PS4, Line 111: usb2_ports[i]
the chip.h also needs to be updated to have array size defined as per config.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38682
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8e88e92989fe40d7bd1c28942e005cb0d862fcb
Gerrit-Change-Number: 38682
Gerrit-PatchSet: 4
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 04 Feb 2020 08:03:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment