Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37990 )
Change subject: soc/intel: Add get_pmbase
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/37990/3/src/soc/intel/cannonlake/pm...
File src/soc/intel/cannonlake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/37990/3/src/soc/intel/cannonlake/pm...
PS3, Line 277:
Please, no blank line here either.
https://review.coreboot.org/c/coreboot/+/37990/3/src/soc/intel/quark/acpi.c
File src/soc/intel/quark/acpi.c:
https://review.coreboot.org/c/coreboot/+/37990/3/src/soc/intel/quark/acpi.c@...
PS3, Line 113: & B_QNC_LPC_PM1BLK_MASK;
No. The first line of code is 101 characters and the second is 92 characters. […]
It was changed to 96 characters at some point.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37990
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6f6295c5eba9eb20e57ab56e7f965c8879e93d2
Gerrit-Change-Number: 37990
Gerrit-PatchSet: 3
Gerrit-Owner: cedarhouse1@comcast.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: cedarhouse1@comcast.net
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-CC: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Thu, 30 Jan 2020 19:16:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: cedarhouse1@comcast.net
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment