Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47530 )
Change subject: soc/intel/common/p2sb: Add helper function to determine p2sb state
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/47530/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/p2sb/p2sb.c:
https://review.coreboot.org/c/coreboot/+/47530/3/src/soc/intel/common/block/...
PS3, Line 21: bool valid_vid = pci_vid == PCI_VENDOR_ID_INTEL;
: bool read_ones = pci_vid == 0xffff;
Why not move these inside the if-blocks?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47530
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d6f9c18160806e289e98c2fa5d290c61434112f
Gerrit-Change-Number: 47530
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 18 Nov 2020 16:20:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment