Philipp Hug has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31477 )
Change subject: riscv: workaround selfboot putting the coreboot table into prog_entry_arg
......................................................................
Patch Set 10:
Patch Set 10: Code-Review-2
We have two conflicting standards here: selfboot and RiscV BBL.
Other arch like arm still use the coreboot table on SELF, even though the kernel requires a devicetree as argument.
Changing the argument of SELF would break libpayload (which could be fixed).
If we'd decide to always use the RiscV bbl calling conventions it needs to be documented in Documentation/. -2 until at least documentation is added to avoid future confusion about conflicting standards.
The WIP libpayload implementation also uses the RISC-V calling convention with hartid+fdt as arguments.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31477
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6929897c7f12d8acb079eeebaef512ae506ca8b
Gerrit-Change-Number: 31477
Gerrit-PatchSet: 10
Gerrit-Owner: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn C
citypw@gmail.com
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 13 Jun 2019 07:19:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment