Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36338 )
Change subject: cpu/x86: make set_msr_bit publicly available
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/36338/1/src/include/cpu/x86/msr.h
File src/include/cpu/x86/msr.h:
https://review.coreboot.org/c/coreboot/+/36338/1/src/include/cpu/x86/msr.h@3...
PS1, Line 306: static inline
It seems to be referenced quite often. Do you really want static inline here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36338
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68b314c917f15fc6e5351de1c539d5a3ae646df8
Gerrit-Change-Number: 36338
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Fri, 25 Oct 2019 20:00:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment