Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32519 )
Change subject: mb/google/sarien: Turn off camera power when s0ix ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/#/c/32519/7/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/#/c/32519/7/src/mainboard/google/sarien/variants... PS7, Line 15: CAM_EN Did you mean to use this below in MS0X?
https://review.coreboot.org/#/c/32519/7/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/#/c/32519/7/src/mainboard/google/sarien/variants... PS7, Line 15: CAM_EN Same here.
https://review.coreboot.org/#/c/32519/7/src/mainboard/google/sarien/variants... PS7, Line 21: /* Turn off camera power */
_PTS can only support Sx but not S0ix I believe according to acpi sepc.
Aah okay. Makes sense.
I can't find what Arg0 would be for s0ix in _PTS.
Like Lijian pointed out, this is not called for S0ix as per ACPI spec.
https://review.coreboot.org/#/c/32519/7/src/soc/intel/cannonlake/acpi/lpit.a... File src/soc/intel/cannonlake/acpi/lpit.asl:
PS7: Can you please split out this change from the mainboard changes?
https://review.coreboot.org/#/c/32519/7/src/soc/intel/cannonlake/acpi/lpit.a... PS7, Line 68: MS0X
Yes, do you have a better idea? I am fine with this.
No, this is fine. I was just curious.