Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41385 )
Change subject: soc/intel/tigerlake: Move PMC PCI resources under PMC device ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41385/4/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.c:
https://review.coreboot.org/c/coreboot/+/41385/4/src/soc/intel/tigerlake/chi... PS4, Line 20: soc_acpi_name
I dislike that this is global and exposed.
it gets used by common/block/xhci, but it may not be needed there since it should fall up to the domain device.
https://review.coreboot.org/c/coreboot/+/41385/4/src/soc/intel/tigerlake/pmc... File src/soc/intel/tigerlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/41385/4/src/soc/intel/tigerlake/pmc... PS4, Line 114: #if CONFIG(HAVE_ACPI_TABLES) : .acpi_name = &soc_acpi_name, : #endif This may not be needed, it should attempt to call the function on the parent device (which should be pci_domain_ops) if this isn't defined here.