[coreboot-gerrit] Change in coreboot[master]: mb/asrock/h110m: rewrite gpio config using macros

[Maxim Polyakov (Code Review)]

Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33565 )

Change subject: mb/asrock/h110m: rewrite gpio config using macros
......................................................................

Patch Set 7:

I think adding new macros with strange names isn't the best way. But only in
this case, I can set the GPIOs configuration, which fully corresponds to the
inteltool log. On the other hand, if I ignore the PAD_CFG0_TRIG_OFF setting (set
RX Level/Edge Configuration (RXEVCFG) to 0 = Level), then I need only 2 macros:
PAD_CFG_NF_TX_DIS and PAD_CFG_NF_RX_DIS, but I don't know what this may affect.

The motherboard works well in both cases.

I would like to get your opinion on this. So, maybe I should ignore Drive '0' setting
for Level/Edge Configuration (bit[26:25] DW0 register) (PAD_CFG0_TRIG_OFF) and use
standard macros (that set RXEVCFG to 0 = passed interrupt signal to next logic as
level signal)? If I understand correctly, interrupts aren't set for the GPIOs for
my board.

Please, comments