Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )
Change subject: hatch: automate creating a new variant in coreboot
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35239/14/util/mainboard/google/hatc...
File util/mainboard/google/hatch/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35239/14/util/mainboard/google/hatc...
PS14, Line 54: # Copy a template file to a new name while substituting the
: # current year for __YEAR__
If it's just a filled-in template, arguably the template gets a copyright (with the year in which th […]
I've had feedback both ways. At first, it said 2019 (as a constant) in the template. I was advised that we want this date to update, so that's how we got __YEAR__ and the copy_tmpl function. Then I got feedback that we shouldn't have a copyright line at all because we're using OWNERS files.
How do we resolve the three competing visions for copyright notices (or lack thereof)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35239
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a5b9c8735faafebb2e4e384cb3346867d64c556
Gerrit-Change-Number: 35239
Gerrit-PatchSet: 14
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Scott Collyer
scollyer@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan
quasisec@google.com
Gerrit-Comment-Date: Mon, 09 Sep 2019 21:17:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment