Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/26138 )
Change subject: soc/intel/common/{block, pch}: Move smihandler common functions into common code ......................................................................
Patch Set 37:
(3 comments)
https://review.coreboot.org/c/coreboot/+/26138/37//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/26138/37//COMMIT_MSG@9 PS37, Line 9: apl
not anymore?
Ack
https://review.coreboot.org/c/coreboot/+/26138/37/src/soc/intel/common/pch/s... File src/soc/intel/common/pch/smm/Kconfig:
https://review.coreboot.org/c/coreboot/+/26138/37/src/soc/intel/common/pch/s... PS37, Line 5: (so far SPT, CNP and ICP)
I would omit this part, as it's likely to never get updated.
Ack
https://review.coreboot.org/c/coreboot/+/26138/37/src/soc/intel/common/pch/s... File src/soc/intel/common/pch/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/26138/37/src/soc/intel/common/pch/s... PS37, Line 4: * Copyright (C) 2020 Intel Corporation.
hm? […]
Ack