Attention is currently required from: Caveh Jalali, Karthik Ramasubramanian, Nick Vaccaro, Pavan Holla, Shelley Chen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81967?usp=email )
Change subject: ec/google/chromeec: Do not fill TypeC ACPI device when UCSI is enabled ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81967/comment/5a7e9123_0f448292 : PS2, Line 7: Hide typec ACPI device if UCSI is supported Please add prefix:
ec/google/chromeec
or
google/chromeec
https://review.coreboot.org/c/coreboot/+/81967/comment/806c4d01_0b90b14e : PS2, Line 19: https://crrev.com/c/5416841 is the change for adding the feature flag Please add a dot/period at the end of sentences.
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/81967/comment/929ede80_763620ce : PS2, Line 435: int Why not bool?
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/81967/comment/311f00cc_392354de : PS2, Line 735: printk(BIOS_INFO, "Cannot check whether EC_FEATURE_UCSI_PPM is available.\n"); Log the return value?
File src/ec/google/chromeec/ec_acpi.c:
https://review.coreboot.org/c/coreboot/+/81967/comment/fd287061_d146bbf3 : PS2, Line 161: /* UCSI implementations do not require an ACPI device : * with mux info since the linux kernel doesn't set : * the muxes. */ Please use the recommended commenting styles.