Attention is currently required from: Caveh Jalali, Karthik Ramasubramanian, Nick Vaccaro, Pavan Holla, Shelley Chen.
5 comments:
Commit Message:
Patch Set #2, Line 7: Hide typec ACPI device if UCSI is supported
Please add prefix:
ec/google/chromeec
or
google/chromeec
Patch Set #2, Line 19: https://crrev.com/c/5416841 is the change for adding the feature flag
Please add a dot/period at the end of sentences.
File src/ec/google/chromeec/ec.h:
Why not bool?
File src/ec/google/chromeec/ec.c:
Patch Set #2, Line 735: printk(BIOS_INFO, "Cannot check whether EC_FEATURE_UCSI_PPM is available.\n");
Log the return value?
File src/ec/google/chromeec/ec_acpi.c:
/* UCSI implementations do not require an ACPI device
* with mux info since the linux kernel doesn't set
* the muxes. */
Please use the recommended commenting styles.
To view, visit change 81967. To unsubscribe, or for help writing mail filters, visit settings.