Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27360 )
Change subject: sdm845: Add interface between CB & QCLib
......................................................................
Patch Set 35:
After looking at how the whole codebase uses CONFIG_CBFS_PREFIX, this request would make sdm845 code different. In fact to fit in with the codebase, the #define for the name, e.g. pmic or aop should be removed...
Yes, having the string inline is certainly acceptable as long as it's only used once in the code (which should be the case for all here). Feel free to do that if you want, but defining a named constant for it isn't "wrong" either. (But if we do have a constant, I think the CBFS prefix should be part of it.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/27360
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d86f360d9e5f1a50f052ab99e821a587e091946
Gerrit-Change-Number: 27360
Gerrit-PatchSet: 35
Gerrit-Owner: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: T.Michael Turney
tturne@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-Comment-Date: Tue, 30 Apr 2019 00:49:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment