Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35039 )
Change subject: mb/google/hatch/var/kindred:: Add enable signal for touch screen
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35039/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/kindred/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35039/1/src/mainboard/google/hatch/...
PS1, Line 81: GPP_D9
I meant if it was configured correctly in gpio.c in coreboot. […]
Yes, I already confirmed GPP_D9 is configured right in baseboard.
I was checking schematic v2.6 when submitting the CL.
I just checked again with v2.7 - no change for this CL is needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35039
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I213d0878bfca1ce4059ec0393f59d8e79e1b274c
Gerrit-Change-Number: 35039
Gerrit-PatchSet: 1
Gerrit-Owner: Philip Chen
philipchen@google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 23 Aug 2019 07:56:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Wu
david_wu@quanta.corp-partner.google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment