Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86181?usp=email )
Change subject: mb/starlabs/starfighter/rpl: Disconnect unused GPIOs ......................................................................
mb/starlabs/starfighter/rpl: Disconnect unused GPIOs
These GPIO's are not used, so disconnect them or set the outputs low accordingly.
Change-Id: If7eab6e3f6ff94054c0101b794b960626d1df92a Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86181 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c 1 file changed, 20 insertions(+), 19 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index c28592e..479f984 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -36,11 +36,11 @@ /* GPD3: Power Button */ PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* GPD4: Sleep S3 */ - PAD_CFG_NF(GPD4, NONE, DEEP, NF1), + PAD_NC(GPD4, NONE), /* GPD5: Sleep S4 */ - PAD_CFG_NF(GPD5, NONE, DEEP, NF1), + PAD_NC(GPD5, NONE), /* GPD6: Sleep A */ - PAD_CFG_NF(GPD6, NONE, DEEP, NF1), + PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ PAD_CFG_GPO(GPD7, 0, PWROK), /* GPD8: Suspend Clock */ @@ -48,7 +48,7 @@ /* GPD9: Wireless LAN Sleep */ PAD_CFG_NF(GPD9, NONE, DEEP, NF1), /* GPD10: Sleep S5 */ - PAD_CFG_NF(GPD10, NONE, DEEP, NF1), + PAD_NC(GPD10, NONE), /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE),
@@ -94,7 +94,6 @@ /* A23: Not Connected */ PAD_NC(GPP_A23, NONE),
- /* B0: Core Vendor ID 0 */ PAD_CFG_NF(GPP_B0, NONE, DEEP, NF1), /* B1: Core Vendor ID 1 */ @@ -120,7 +119,7 @@ /* B11: I2C PMC PD Interrupt */ PAD_CFG_NF(GPP_B11, NONE, DEEP, NF1), /* B12: PM SLP S0 */ - PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), + PAD_NC(GPP_B12, NONE), /* B13: PLT RST */ PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), /* B14: Not Connected */ @@ -247,7 +246,7 @@ /* E1: Not Connected */ PAD_NC(GPP_E1, NONE), /* E2: Not Connected */ - PAD_CFG_GPO(GPP_E2, 1, PLTRST), + PAD_NC(GPP_E2, NONE), /* E3: WiFi RF Kill */ PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE), /* E4: Retimer Force Power */ @@ -307,18 +306,20 @@ PAD_NC(GPP_F5, NONE), /* F6: Not used */ PAD_NC(GPP_F6, NONE), - /* F7: GPPC_F7 */ - PAD_NC(GPP_F7, NONE), + /* F7: TBT LSX VCCIO Weak Internal PD 20K + Low: 1.8V + High: 3.3V */ + PAD_CFG_GPO(GPP_F7, 0, DEEP), /* F8: Not Connected */ PAD_NC(GPP_F8, NONE), /* F9: EC Sleep S0 */ - PAD_CFG_GPO(GPP_F9, 1, PLTRST), + PAD_NC(GPP_F9, NONE), /* F10: Weak Internal PD 20K */ - PAD_CFG_GPO(GPP_F10, 1, PLTRST), + PAD_CFG_GPO(GPP_F10, 0, PLTRST), /* F11: TPM ID */ - PAD_CFG_GPI_TRIG_OWN(GPP_F11, NONE, DEEP, OFF, ACPI), + PAD_NC(GPP_F11, NONE), /* F16: Not Connected */ - PAD_CFG_GPO(GPP_F16, 1, RSMRST), + PAD_NC(GPP_F16, NONE), /* F17: Not used Touch Panel Reset */ PAD_NC(GPP_F17, NONE), /* F18: Not used Touch Panel Interrupt */ @@ -328,16 +329,16 @@ /* F20: CPU M.2 SSD Reset */ PAD_CFG_GPO(GPP_F20, 1, PLTRST), /* F21: GPPC_F21 */ - PAD_CFG_NF(GPP_F21, NONE, DEEP, NF1), + PAD_NC(GPP_F21, NONE), /* F22: Not Connected */ PAD_NC(GPP_F22, NONE), /* F23: Not Connected */ PAD_NC(GPP_F23, NONE),
/* H0: PCH M.2 SSD Reset */ -PAD_CFG_GPO(GPP_H0, 1, PLTRST), + PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ - PAD_CFG_GPO(GPP_H1, 1, PLTRST), + PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ @@ -357,7 +358,7 @@ /* H12: Not Connected */ PAD_NC(GPP_H12, NONE), /* H13: PCH M.2 SSD Device Sleep */ -PAD_CFG_GPO(GPP_H13, 0, PLTRST), + PAD_CFG_GPO(GPP_H13, 0, PLTRST), /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), /* H15: DDPB Control Clock */ @@ -384,9 +385,9 @@ /* S1: Not Connected */ PAD_NC(GPP_S1, NONE), /* S2: DMIC Clock */ - PAD_CFG_NF(GPP_S2, NONE, DEEP, NF2), + PAD_NC(GPP_S2, NONE), /* S3: DMIC Data */ - PAD_CFG_NF(GPP_S3, NONE, DEEP, NF2), + PAD_NC(GPP_S3, NONE), /* S4: Not Connected */ PAD_NC(GPP_S4, NONE), /* S5: Not Connected */