[coreboot-gerrit] [M] Change in coreboot[main]: soc/mediatek/mt8196: Add tracker driver

[Jarried Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.

Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84929?usp=email )

Change subject: soc/mediatek/mt8196: Add tracker driver
......................................................................

Patch Set 9:

(7 comments)

File src/soc/mediatek/mt8196/tracker.c:

https://review.coreboot.org/c/coreboot/+/84929/comment/7e6d2731_b59ae87c?usp... :
PS9, Line 104: read32
read32p

https://review.coreboot.org/c/coreboot/+/84929/comment/d45b9e73_763fa40e?usp... :
PS9, Line 105: reg_low
move to next line, and allign to BIOS_INFO

https://review.coreboot.org/c/coreboot/+/84929/comment/4d709e7a_6b046e4c?usp... :
PS9, Line 106: read32
read32p

https://review.coreboot.org/c/coreboot/+/84929/comment/ceb98fcc_c58e6a96?usp... :
PS9, Line 106: read32
read32p

https://review.coreboot.org/c/coreboot/+/84929/comment/60323ca0_463acdde?usp... :
PS9, Line 107: read32
read32p

https://review.coreboot.org/c/coreboot/+/84929/comment/b3f04571_e873a212?usp... :
PS9, Line 107: read32
read32p

https://review.coreboot.org/c/coreboot/+/84929/comment/61ce2380_0ade553b?usp... :
PS9, Line 115: reg_entry = ((u64)read32((void *)reg_high)) << 32 | read32((void *)reg_low);
             : 			printk(BIOS_INFO, "%#lx:%#x:%#x:%#x:%#x:%#llx\n", reg_low,
             : 					read32((void *)reg_log), read32((void *)reg_id),
             : 					read32((void *)reg_low), read32((void *)reg_high), reg_entry);
please use read32p