8 Nov
2021
8 Nov
'21
3:46 a.m.
Attention is currently required from: Paul Menzel, Arthur Heymans. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58934 )
Change subject: Documentation/coding_style.md: Avoid weakly linked symbols ......................................................................
Patch Set 2:
(1 comment)
File Documentation/contributing/coding_style.md:
https://review.coreboot.org/c/coreboot/+/58934/comment/7c1728a8_f396dc82 PS2, Line 971: conditional Can you add some link to patches as references for "good implementation"?
I'm concerned people may start adding lots of #if , which may be even worse.
--
To view, visit https://review.coreboot.org/c/coreboot/+/58934
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If70d38c5c646c1e8365bb16d3292cebb2787eba2
Gerrit-Change-Number: 58934
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Hung-Te Lin hungte@chromium.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 08 Nov 2021 02:46:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment