Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52198 )
Change subject: soc/amd/cezanne: add SMU settings to devicetree
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/cezanne/fsp_m_params.c:
https://review.coreboot.org/c/coreboot/+/52198/comment/de2213b6_6fbd213e
PS2, Line 94: /* all following fields being 0 is a valid config */
this patch shouldn't be merged before the fsp sode change has landed in the build system. without that fsp side change we'll see weird misbehavior when setting some values to non-zero due to the changed offsets
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52198
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifbcc85cc10d59f1418bbf0ed4a0dc7549d589a26
Gerrit-Change-Number: 52198
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 19 Apr 2021 20:32:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment