Attention is currently required from: Michał Żygowski, Tim Wawrzynczak. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63493 )
Change subject: soc/intel/alderlake: add chipset devicetree for ADL-S ......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63493/comment/fce60377_38655a5e PS1, Line 11: 619015
Did you mean 619501 ADL processors EDS?
Sure did. Done
File src/soc/intel/alderlake/chipset_pch_s.cb:
https://review.coreboot.org/c/coreboot/+/63493/comment/41f25a4e_c1fccaeb PS1, Line 4:
Missing power limits. PL1 PL2 DOC #619501 Table 15 and 19 […]
Added power limits as per doc
https://review.coreboot.org/c/coreboot/+/63493/comment/298dc62d_42d00ec0 PS1, Line 12: device pci 05.0 alias ipu off end
Not present on PCH-S
Done
https://review.coreboot.org/c/coreboot/+/63493/comment/a34d13c6_279fd646 PS1, Line 14: device pci 06.2 alias pcie4_1 off end
If we talk about ADL-S CPU only, it does not contain PCIe 6.2 (only H, P and U15 lines do).
Done
https://review.coreboot.org/c/coreboot/+/63493/comment/aa88b9a6_ec2fb2fb PS1, Line 19: device pci 12.0 alias ish off end
pci 11. […]
Done
https://review.coreboot.org/c/coreboot/+/63493/comment/0b463d73_c7f4e1fe PS1, Line 25: device usb 0.0 alias xhci_root_hub off : chip drivers/usb/acpi : device usb 2.0 alias usb2_port1 off end : end : chip drivers/usb/acpi : device usb 2.1 alias usb2_port2 off end : end : chip drivers/usb/acpi : device usb 2.2 alias usb2_port3 off end : end : chip drivers/usb/acpi : device usb 2.3 alias usb2_port4 off end : end : chip drivers/usb/acpi : device usb 2.4 alias usb2_port5 off end : end : chip drivers/usb/acpi : device usb 2.5 alias usb2_port6 off end : end : chip drivers/usb/acpi : device usb 2.6 alias usb2_port7 off end : end : chip drivers/usb/acpi : device usb 2.7 alias usb2_port8 off end : end : chip drivers/usb/acpi : device usb 2.8 alias usb2_port9 off end : end : chip drivers/usb/acpi : device usb 2.9 alias usb2_port10 off end : end : chip drivers/usb/acpi : device usb 3.0 alias usb3_port1 off end : end : chip drivers/usb/acpi : device usb 3.1 alias usb3_port2 off end : end : chip drivers/usb/acpi : device usb 3.2 alias usb3_port3 off end : end : chip drivers/usb/acpi : device usb 3.3 alias usb3_port4 off end : end : end
10 USB 3.x ports and 14 USB2. […]
Done