Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33839 )
Change subject: mb/protectli/vault_kbl: Add FW6 support
......................................................................
Patch Set 8:
Patch Set 8: Code-Review+1
(2 comments)
I see there aren't any thermal zones set up for IT8772 fan control, how are you handling that?
There is a fan connector on the mainboard, but it is not used on FW6. Left the fan enabled in case somebody would want to use it. it is configured for fixed speed, replicating vendor BIOS configuration.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33839
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03e8e8db5d827fe113280f2a6376d364edf42870
Gerrit-Change-Number: 33839
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Mar 2020 11:47:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment