Attention is currently required from: Raul Rangel, Martin Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52359 )
Change subject: mb/google/zork/smihandler: only print warning in mainboard_smi_gpi ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/zork/smihandler.c:
https://review.coreboot.org/c/coreboot/+/52359/comment/06df2b57_a7ef68b4 PS2, Line 15: chromeec_smi_process_events
Maybe we should actually fix this? The EC should be able to send SMI via eSPI.
unless it uses a gpio pin configured as PAD_SMI for that which it doesn't do from the mainboard's gpio configuration code, mainboard_smi_gpi isn't expected to be called. the EC on zork signals SCIs via a separate pin, but from the code in coreboot there's no SMI pin from the EC to the APU