Attention is currently required from: Aaron Durbin, Furquan Shaikh, Hung-Te Lin.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37262?usp=email )
Change subject: util/cbfstool: Add '%<alignment>' in flashmap descriptor
......................................................................
Patch Set 15: Code-Review+2
(2 comments)
File util/cbfstool/default.fmd:
https://review.coreboot.org/c/coreboot/+/37262/comment/eaa5c478_55ef7860 :
PS13, Line 18: %0
When I try to build a image (Minimal x86 fake board): […]
Yeah, I think aligning the FMAP to 4K would be the best solution in that case.
File util/cbfstool/fmd_scanner.l:
https://review.coreboot.org/c/coreboot/+/37262/comment/f72d1b04_94e820db :
PS13, Line 31: . return *yytext;
',' is removed.
Okay. I guess I'm still confused why the `%` token needs to be treated differently. Why can't you just let `%` fall through to the default `return *yytext;` rule too?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37262?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26b394590c28667a4afcd521c7caa2009b5b98a9
Gerrit-Change-Number: 37262
Gerrit-PatchSet: 15
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Thu, 15 Jun 2023 21:02:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment