[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake/bootblock: Do initial SoC commit till bootblock

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36550 )

Change subject: soc/intel/tigerlake/bootblock: Do initial SoC commit till bootblock
......................................................................

Patch Set 9: Code-Review+1

(2 comments)

A few nits.

https://review.coreboot.org/c/coreboot/+/36550/9/src/soc/intel/tigerlake/boo... 
File src/soc/intel/tigerlake/bootblock/pch.c:

https://review.coreboot.org/c/coreboot/+/36550/9/src/soc/intel/tigerlake/boo... 
PS9, Line 106: 0xFFFFFFFF
use lower case.

https://review.coreboot.org/c/coreboot/+/36550/9/src/soc/intel/tigerlake/boo... 
File src/soc/intel/tigerlake/bootblock/report_platform.c:

https://review.coreboot.org/c/coreboot/+/36550/9/src/soc/intel/tigerlake/boo... 
PS9, Line 40: static uint8_t get_dev_revision(pci_devfn_t dev)
            : {
            : 	return pci_read_config8(dev, PCI_REVISION_ID);
            : }
            : 
            : static uint16_t get_dev_id(pci_devfn_t dev)
            : {
            : 	return pci_read_config16(dev, PCI_DEVICE_ID);
            : }
static inline?