Attention is currently required from: Jayvik Desai, Kapil Porwal, Matt DeVillier, Pranava Y N, Subrata Banik, Weimin Wu.
Tongtong Pan has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/86542?usp=email )
Change subject: mb/google/fatcat/var/felino: Modify the overridetree.cb for enable touchpad
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/fatcat/variants/felino/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/86542/comment/8142e2ef_5ed8f0d8?usp... :
PS1, Line 237: register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_E18_IRQ)"
needs tabs vs spaces here and 3 lines below
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86542?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I47667120f098727f0d3ef05c17ea48f62b13c135
Gerrit-Change-Number: 86542
Gerrit-PatchSet: 2
Gerrit-Owner: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Mon, 24 Feb 2025 06:13:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com