Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32907 )
Change subject: Documentation: How to run coreboot on PC Engines APU1
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32907/4/Documentation/mainboard/pcengines/ap...
File Documentation/mainboard/pcengines/apu1.md:
https://review.coreboot.org/#/c/32907/4/Documentation/mainboard/pcengines/ap...
PS4, Line 76: **apu1 platform with marked in SPI header and SPI flash chip**
There might be the same confusion about SPI_DI and SPI_DO signal directions that got fixed for apu2 document.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32907
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If79693e893c4afe52bf1c9aa8017ac6f650a96e4
Gerrit-Change-Number: 32907
Gerrit-PatchSet: 4
Gerrit-Owner: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Piotr Kleinschmidt
piotr.kleinschmidt@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 11 Jun 2019 06:40:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment