29 Oct
2020
29 Oct
'20
10:04 p.m.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46661 )
Change subject: sc7180: Add Modem region in memlayout to avoid modem cleanup in Secboot reboot. ......................................................................
Patch Set 5: Code-Review+2
Okay, this patch looks good now, but I still can't merge it because of the weird dependency chain you built here. We don't want to merge the herobrine patches yet, or that HACK patch, and CB:45418 is basically just an earlier version of this patch that should just be squashed into it.
So please squash this patch and CB:45418 together and rearrange them so that the resulting patch stands at the bottom of the dependency chain, so I can merge it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/46661
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4592ca66d3d0db4c4768be4cd27422fe9f786b8
Gerrit-Change-Number: 46661
Gerrit-PatchSet: 5
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 29 Oct 2020 22:04:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment