[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Update ACPI files

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37781 )

Change subject: soc/intel/tigerlake: Update ACPI files
......................................................................

Patch Set 14:

(3 comments)

https://review.coreboot.org/c/coreboot/+/37781/13/src/soc/intel/tigerlake/ac... 
File src/soc/intel/tigerlake/acpi/pch_clock_ctl.asl:

https://review.coreboot.org/c/coreboot/+/37781/13/src/soc/intel/tigerlake/ac... 
PS13, Line 28: Add(SBRG, Add(ShiftLeft(ICKP, 16), R_ICLK_PCR_CAMERA1)), 0x40
> can u move this to a function so its easy for readability if possible ?

Make simplify for readability

https://review.coreboot.org/c/coreboot/+/37781/13/src/soc/intel/tigerlake/ac... 
PS13, Line 61: Store(CLK1, Local0)
             : 				Store(Or(And(Local0, Not(B_ICLK_PCR_REQUEST)), ShiftLeft(Arg1, 1)), CLK1)
> this code be a helper function as well hence u can pass argument for readability

Ack

https://review.coreboot.org/c/coreboot/+/37781/13/src/soc/intel/tigerlake/ac... 
PS13, Line 103: Store(CLK1, Local0)
              : 				Store(Or(And(Local0, Not(B_ICLK_PCR_FREQUENCY)), Arg1), CLK1)
> same

Ack