Attention is currently required from: Jes Klinke, Christian Walter, Julius Werner.
Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63158 )
Change subject: tpm: Accept Google Ti50 TPM DID:VID
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/63158/comment/2e4d7d69_b96f1ed1
PS1, Line 515: if (tpm_first_access_this_boot()) {
: /* This is called for the side-effect of printing the firmware version
: string */
: cr50_get_firmware_version(&ver);
: }
cr50_set_board_cfg() we definitely only want to do for Cr50, not Ti50 as it emits the longer interru […]
This is in a ti50 only block, and I would have expected this code to be in a cr50 only block
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63158
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e1f8eb9b94fc2d5689656335dc1135b47880986
Gerrit-Change-Number: 63158
Gerrit-PatchSet: 1
Gerrit-Owner: Jes Klinke
jbk@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jett Rink
jettrink@chromium.org
Gerrit-CC: Jett Rink
jettrink@google.com
Gerrit-Attention: Jes Klinke
jbk@chromium.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 28 Mar 2022 21:42:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jes Klinke
jbk@chromium.org
Comment-In-Reply-To: Jett Rink
jettrink@google.com
Gerrit-MessageType: comment