Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31066 )
Change subject: mb/lenovo/x131e: devicetree updates
......................................................................
Patch Set 1:
(2 comments)
Two commits would be nice, so they can be easily reverted in case of errors.
https://review.coreboot.org/#/c/31066/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31066/1//COMMIT_MSG@7
PS1, Line 7: mb/lenovo/x131e: devicetree updates
Please make this a statement by using a verb (in imperative mood):
Update devicetree
Otherwise it’s not clear, what is done with the updates: added, removed, …?
https://review.coreboot.org/#/c/31066/1//COMMIT_MSG@10
PS1, Line 10:
Please elaborate, how you tested this.
Non-working mSATA slot, is working now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31066
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4cfefb06556c9d69bc8e4a4f9d112246885c253a
Gerrit-Change-Number: 31066
Gerrit-PatchSet: 1
Gerrit-Owner: James Ye
jye836@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: James Ye
jye836@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 24 Jan 2019 11:16:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment