Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39002 )
Change subject: [WIP]lib/edid_fill_fb: Support multiple framebuffers ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39002/2/src/include/framebuffer_inf... File src/include/framebuffer_info.h:
https://review.coreboot.org/c/coreboot/+/39002/2/src/include/framebuffer_inf... PS2, Line 25: edid_ EDID is about the modeline (hardware interface) while the framebuffer is just software configuration. I'd try to get rid of it in all the identifiers.
https://review.coreboot.org/c/coreboot/+/39002/2/src/include/framebuffer_inf... PS2, Line 26: struct edid_fb_info *fb_new_framebuffer_info(void); Could we make this part of fb_fill_framebuffer_info*()?
Maybe we could even get rid of the `valid` attribute (if it's not valid, don't add it to the list in the first place).