Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39221 )
Change subject: vboot: Clean up pre-RAM use of vboot_recovery_mode_enabled()
......................................................................
Patch Set 2:
*ping*
Looks like I forgot about this patch and maybe reviewers did too. Is this something that we can still find agreement on? I paged out all context on this but I think according to my latest comments I still thought that this is the best option. If not, how else should we resolve the situation? As I understand, booting with vboot still breaks at runtime on a bunch of older boards without this patch right now (or did we have some alternative fix that I forgot about?).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39221
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31bfc7663724fdacab9955224dcaf650d1ec1c3c
Gerrit-Change-Number: 39221
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Frans Hendriks
fhendriks@eltan.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Apr 2020 01:29:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment