Attention is currently required from: Frank Wu, Jason Glenesk, Raul Rangel, Martin L Roth, Matt DeVillier, Paul Menzel, Jon Murphy, Fred Reitberger, Karthik Ramasubramanian.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69827 )
Change subject: soc/amd/mendocino: Increase CBFS_MCACHE size
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69827/comment/5a2c707b_5718abdc
PS1, Line 11: This reduction along with the available free space in PSP shared buffer
: (32 KiB)
That backup space is in MP2 SRAM and not in PSP's SRAM. So PSP has to work with their MP2 FW team and still bump it up.
Also if you look at the layout closely, Bootblock, ROM Stage, FSP-M also closely follow PSP_SHARED_MEM. So they need to be moved around which needs a revisit of memory map.
I have tried increasing the PSP_SHARED_MEM size without any corresponding PSP FW changes. The system ended up not booting.
got it. Thanks for explaining that!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69827
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I35e1a8c6d73e0870b6a43aac604f83a0b6c3aabe
Gerrit-Change-Number: 69827
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: John Su
john_su@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 21 Nov 2022 19:55:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment