Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38743 )
Change subject: nb/intel/haswell/peg: Add PEG driver stub ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38743/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38743/2//COMMIT_MSG@11 PS2, Line 11: sandybridge Sandybridge
https://review.coreboot.org/c/coreboot/+/38743/2//COMMIT_MSG@13 PS2, Line 13: noveau Nouveau
https://review.coreboot.org/c/coreboot/+/38743/2//COMMIT_MSG@13 PS2, Line 13: Without patches dmesg reports noveau is : unable to read the ROM of the dGPU as it has an invalid checksum (I : checked that the ROM in CBFS is correct). Did you talk to the Nouveau folks? Sounds like something that can be fixed in Linux.
https://review.coreboot.org/c/coreboot/+/38743/2//COMMIT_MSG@15 PS2, Line 15: drm DRM
https://review.coreboot.org/c/coreboot/+/38743/2//COMMIT_MSG@16 PS2, Line 16: initalized initialized
https://review.coreboot.org/c/coreboot/+/38743/2/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/acpi/peg.asl:
https://review.coreboot.org/c/coreboot/+/38743/2/src/northbridge/intel/haswe... PS2, Line 19: Name (_ADR, 0x00010000) Use tabs?