Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34385 )
Change subject: drivers/i2c/dw: Don't try to generate unselected speeds in ACPI table
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34385/2/src/drivers/i2c/designware/...
File src/drivers/i2c/designware/dw_i2c.c:
https://review.coreboot.org/c/coreboot/+/34385/2/src/drivers/i2c/designware/...
PS2, Line 853: for (i = 0; i < DW_I2C_SPEED_CONFIG_COUNT; i++)
Do we need the loop at all?
https://review.coreboot.org/c/coreboot/+/34385/2/src/drivers/i2c/designware/...
PS2, Line 854: bcfg->speed
What happens when bcfg->speed is not set? Do we need a default in that case?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34385
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07207ec95652e8af1a42bfe31214f61a183a134e
Gerrit-Change-Number: 34385
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 17 Jul 2019 15:50:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment