[coreboot-gerrit] Change in coreboot[master]: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build ...

[Nico Huber (Code Review)]

Attention is currently required from: Bill XIE, Patrick Rudolph, Angel Pons, Julius Werner, Arthur Heymans, Michael Niewöhner, Kyösti Mälkki, Aaron Durbin.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51671 )

Change subject: arch/x86: Init firmware pointer for EC SMSC KBC1098/KBC1126 at build time
......................................................................

Patch Set 22: Code-Review+1

(1 comment)

File src/arch/x86/bootblock.ld:

https://review.coreboot.org/c/coreboot/+/51671/comment/67393243_b15dfa5f 
PS22, Line 57: _ID_SECTION_END - _ECFW_PTR
> It can only happen when someone messes up the code.

Exactly that. And ECFW_PTR_ADDR is a Kconfig, so we kind of have to expect
that it might change. Which makes me realize the following: If the Kconfig
is used in arch/x86/ then it should be declared in arch/x86/Kconfig, along
with a help text that describes this constraint (i.e. must be below the
reset vector or FIT pointer if present). The EC Kconfig should only set
the default number.