[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Generate ACPI CRAT objects in cb

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47727 )

Change subject: soc/amd/picasso: Generate ACPI CRAT objects in cb
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47727/3/src/include/acpi/acpi.h 
File src/include/acpi/acpi.h:

https://review.coreboot.org/c/coreboot/+/47727/3/src/include/acpi/acpi.h@311 
PS3, Line 311: struct acpi_crat_header
> Maybe typedef this, like on line 303. […]

not using typedefs here might not be completely consistent, but is the better option in the long run; see also https://doc.coreboot.org/coding_style.html#typedefs on that