Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44880 )
Change subject: security/intel/txt: Improve MTRR setup for GETSEC[ENTERACCS]
......................................................................
Patch Set 8:
Patch Set 8:
Can the MTRR operations moved to C?
That would make it easier to review and it would be possible to use existing common code.
I use the same assembly code to invoke GETSEC in romstage, and I need to tear down CAR before reprogramming the MTRRs. And this is required on LT-CX platforms, since a reset with secrets in memory will block the memory controller until one invokes the SCLEAN function of the BIOS ACM.
So yes, it could be done, but would not work for pre-RAM stages.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44880
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d411f6450928357544be20250262c2005d1e75d
Gerrit-Change-Number: 44880
Gerrit-PatchSet: 8
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 11 Oct 2020 16:34:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment