Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33776 )
Change subject: asus/am1i-a: set UART_FOR_CONSOLE to 1 instead of default 0 ......................................................................
Patch Set 1:
(1 comment)
Patch Set 1:
(1 comment)
Patch Set 1: Code-Review+1
For some reason the code sets up SP2 instead of SP1, so super slow serial as a result of very high default divider is expected.
Another option is to have the romstage set up SP1 (or both)?
src/mainboard/asus/am1i-a/romstage.c -#define SERIAL_DEV PNP_DEV(0x2e, IT8623E_SP2) +#define SERIAL_DEV PNP_DEV(0x2e, IT8623E_SP1)
I would prefer the bug to be fixed. What about making sure the correct UART is initialized according to UART_FOR_CONSOLE?
I'll try to set up both SP1 and SP2 - so that, if someone switches this setting to another port, he wouldn't encounter this problem.
https://review.coreboot.org/#/c/33776/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33776/1//COMMIT_MSG@12 PS1, Line 12: (this board has two COM ports).
Very well, but which one is UART 0 and which one is UART 1? Where should one expect the logs to come […]
UART 0 = COM 1 (9 pins on-board connector), UART 1 = COM 2 (serial port connector)