Tommie Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37906 )
Change subject: mb/google/octopus: Add two new sku IDs for foob ......................................................................
Patch Set 3: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/37906/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/gpio.c:
https://review.coreboot.org/c/coreboot/+/37906/1/src/mainboard/google/octopu... PS1, Line 42: sku1_override_table
non_touchscreen_override_table might be more meaningful?
Done
https://review.coreboot.org/c/coreboot/+/37906/1/src/mainboard/google/octopu... PS1, Line 75: google_chromeec_cbi_get_sku_id(&sku_id);
get_board_sku() from mainboard.c? And the benefit is we don't need to query from EC again.
Done
https://review.coreboot.org/c/coreboot/+/37906/1/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/variant.c:
https://review.coreboot.org/c/coreboot/+/37906/1/src/mainboard/google/octopu... PS1, Line 4: * Copyright 2018 Google LLC
2019?
Done
https://review.coreboot.org/c/coreboot/+/37906/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/foob/variant.c:
https://review.coreboot.org/c/coreboot/+/37906/2/src/mainboard/google/octopu... PS2, Line 33: google_chromeec_cbi_get_sku_id(&sku_id);
This is another place for using get_board_sku()? On the other hand, if no_touchscreen_sku() always n […]
Done