Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35167 )
Change subject: soc/skylake/vr_config: Add VR config for Skylake S ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35167/3/src/soc/intel/skylake/vr_co... File src/soc/intel/skylake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/35167/3/src/soc/intel/skylake/vr_co... PS3, Line 148: uint16_t icc_max[NUM_VR_DOMAINS] = { : VR_CFG_AMP(11.1), : VR_CFG_AMP(40), : VR_CFG_AMP(48), : VR_CFG_AMP(48), : };
Specifically, NUM_VR_DOMAINS = 5 for FSP 1. […]
Right. In the original platform support only devicetree values were used, thus this code was never run. Looking at the FSP documentation I can't even tell if FSP2.0 uses 4 or 5 VR_DOMAINS for SKL. I'd guess 5 as the register takes 5 values at maximum.