build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43745 )
Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43745/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/madoo/gpio.c:
https://review.coreboot.org/c/coreboot/+/43745/1/src/mainboard/google/dedede... PS1, Line 9: PAD_CFG_NF(GPP_A13, NONE, DEEP, NF1), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43745/1/src/mainboard/google/dedede... PS1, Line 11: PAD_NC(GPP_D12, NONE), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43745/1/src/mainboard/google/dedede... PS1, Line 19: PAD_NC(GPP_S2, NONE), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/43745/1/src/mainboard/google/dedede... PS1, Line 28: } adding a line without newline at end of file