Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34284 )
Change subject: device/oprom: Lists all supported vesa mode by oprom ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34284/4/src/device/oprom/realmode/x... File src/device/oprom/realmode/x86.c:
https://review.coreboot.org/c/coreboot/+/34284/4/src/device/oprom/realmode/x... PS4, Line 243: if (vbe_check_for_failure(X86_AH))
technically VESA_GET_INFO can't return 0x3 because as per VBE Return Status description 0x3 signifie […]
Done
https://review.coreboot.org/c/coreboot/+/34284/4/src/device/oprom/realmode/x... PS4, Line 305: vbe_oprom_supported_mode_list();
good catch
Done