Attention is currently required from: Martin L Roth, Maximilian Brune, Patrick Georgi, Philipp Hug.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81410?usp=email )
Change subject: arch/riscv: add Kconfig variable RISCV_SOC_HAS_MENVCFG
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
The mistake I made on the first iteration of this was to create a runtime test for the feature. That's a very kernel approach.
This is firmware, and you're expected to correctly statically configure for the SOC you're on. So, we expect you to set this variable correctly for the SOC.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81410?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I627dde377708cde2491d4abe625c482d64f7aa87
Gerrit-Change-Number: 81410
Gerrit-PatchSet: 3
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Thu, 21 Mar 2024 16:21:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment