[coreboot-gerrit] Change in coreboot[master]: arch/x86/smbios: Add SMBIOS type8 data

[Jonathan Zhang (Code Review)]

Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40545 )

Change subject: arch/x86/smbios: Add SMBIOS type8 data
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40545/7/src/include/smbios.h 
File src/include/smbios.h:

https://review.coreboot.org/c/coreboot/+/40545/7/src/include/smbios.h@586 
PS7, Line 586: uint8_t
> I just follow other's way

it is better to use enums defined above here.

https://review.coreboot.org/c/coreboot/+/40545/7/src/include/smbios.h@591 
PS7, Line 591: uint8_t
> Someone ask me not to use C99 type, I'm not so sure which one I need to use for typedef, it seems bo […]

Hi Bryant, a rule is to use/follow same style in a file. So you could use kernel notation for your additions to follow existing style, but then have another commit to change the style.