Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48246 )
Change subject: soc/intel/common/block/acpi: Add soc MADT IOAPIC callback ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48246/8/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/acpi.h:
https://review.coreboot.org/c/coreboot/+/48246/8/src/soc/intel/common/block/... PS8, Line 72: acpi_ioapic_t
I was being consistent with acpi_cstate_t and acpi_tstate_t, but they are defined by the acpi libra […]
I have to admit, I didn't know (at least not from the top of my head) that this is a common pattern in ACPI code. It seems to be another corner that doesn't quite look like common coreboot code.
https://review.coreboot.org/c/coreboot/+/48246/8/src/soc/intel/common/block/... PS8, Line 72: __packed
I was being consistent with acpi_cstate_t and acpi_tstate_t definitions.
Ah, interesting. It looks like somebody just copied the pattern by accident from structs that are part of actual ACPI tables and need a specific representation.