[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/common: SMBus complete_command()

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/21120 )

Change subject: sb/intel/common: SMBus complete_command()
......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/21120/11/src/southbridge/intel/common/smbus.... 
File src/southbridge/intel/common/smbus.c:

https://review.coreboot.org/#/c/21120/11/src/southbridge/intel/common/smbus.... 
PS11, Line 85: static int cb_err_from_stat(u8 status)
             : {
             : 	/* Ignore the "In Use" status... */
             : 	status &= ~(SMBHSTSTS_SMBALERT_STS | SMBHSTSTS_INUSE_STS);
             : 
             : 	if (status == SMBHSTSTS_INTR)
             : 		return 0;
             : 
             : 	return SMBUS_ERROR;
             : }
> this seems to have false positives on at least ich10 with i2c_block_read.

Please elaborate. Like set DEBUG_SMBUS=y.