Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44359 )
Change subject: mainboard/google/volteer: Enable long cr50 ready pulses ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44359/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/44359/4/src/mainboard/google/voltee... PS4, Line 61: config CR50_USE_LONG_INTERRUPT_PULSES : bool : default y
Actually, I am starting to think that this Kconfig setting belongs in soc/tigerlake. That is, if the SoC is Tiger Lake, and TPM_CR50 is selected, then we should autumatically also select CR50_USE_LONG_INTERRUPT_PULSES.
That sounds fine. You can do it under "config CHROMEOS" in tigerlake.
I have seen config clauses declaring that the default should depend on some other setting, but I do not know if such a default in the soc directory would properly override the default "n" from drivers.
That should work fine. soc/*/Kconfig gets sourced before the drivers. So, it should do the right thing.