Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38291 )
Change subject: libpayload: Add support for link time optimization
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38291/6/payloads/libpayload/Makefil...
File payloads/libpayload/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38291/6/payloads/libpayload/Makefil...
PS6, Line 69: -fuse-linker-plugin -fno-fat-lto-objects
use-linker-plugin tells the compiler to tell the linker to use plugins, among them, the linker's LTO […]
For fat-lto-objects, I think it's more likely that the inclusion of the compiler data rather than the object code is triggering the extra warnings (since normal builds also include the object code but don't generate the warnings). It didn't generate any extra warnings when enabled on the coreboot tree so I think it should be safe to stick with the defaults.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38291
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I048f2ff6298ed0d891098942e1e8b29d35487b91
Gerrit-Change-Number: 38291
Gerrit-PatchSet: 11
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 25 Aug 2020 20:49:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment